Skip to content

Remove eval_always for lib_features. #91330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

cjgillot
Copy link
Contributor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 28, 2021
@bors
Copy link
Collaborator

bors commented Nov 28, 2021

⌛ Trying commit 877b2d7 with merge 49fd54458898c27659727aca3e321a6a4296a642...

@bors
Copy link
Collaborator

bors commented Nov 28, 2021

☀️ Try build successful - checks-actions
Build commit: 49fd54458898c27659727aca3e321a6a4296a642 (49fd54458898c27659727aca3e321a6a4296a642)

@rust-timer
Copy link
Collaborator

Queued 49fd54458898c27659727aca3e321a6a4296a642 with parent db9d361, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (49fd54458898c27659727aca3e321a6a4296a642): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 29, 2021
@Aaron1011
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 29, 2021

📌 Commit 877b2d7 has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2021
@bors
Copy link
Collaborator

bors commented Nov 30, 2021

⌛ Testing commit 877b2d7 with merge 90912e6...

@bors
Copy link
Collaborator

bors commented Nov 30, 2021

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 90912e6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 30, 2021
@bors bors merged commit 90912e6 into rust-lang:master Nov 30, 2021
@rustbot rustbot added this to the 1.59.0 milestone Nov 30, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (90912e6): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@cjgillot cjgillot deleted the no-ee-features branch November 30, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants